Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue 249] Remove or convert HTML from issue/merge request description #249 #276

Merged
merged 9 commits into from
Jul 12, 2022
Merged

[issue 249] Remove or convert HTML from issue/merge request description #249 #276

merged 9 commits into from
Jul 12, 2022

Conversation

sibasankarnayak
Copy link
Contributor

@sibasankarnayak sibasankarnayak commented Feb 24, 2022 •
edited
Loading

removed the html with details tag to make the notification more cleaner

ticket here
fixes #249

@mattermod
Copy link
Contributor

Hello @sibasankarnayak,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@codecov
Copy link

codecov bot commented Feb 24, 2022 •
edited
Loading

Codecov Report

Merging #276 (fc87081) into master (aec8208) will increase coverage by 0.10%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   28.59%   28.70%   +0.10%     
==========================================
  Files          20       20              
  Lines        2595     2599       +4     
==========================================
+ Hits          742      746       +4     
  Misses       1769     1769              
  Partials       84       84
Impacted Files Coverage Δ
server/webhook/issue.go 83.33% <66.66%> (ø)
server/webhook/merge_request.go 88.60% <100.00%> (ø)
server/webhook/webhook.go 55.38% <100.00%> (+2.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec8208...fc87081. Read the comment docs.

hanzei
hanzei requested changes Mar 1, 2022
View reviewed changes
server/webhook/merge_request.go Outdated Show resolved Hide resolved
webapp/package.json Outdated Show resolved Hide resolved
server/webhook/merge_request.go Outdated Show resolved Hide resolved
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 1, 2022
@hanzei hanzei added this to the v1.5.0 milestone Mar 1, 2022
hanzei
hanzei requested changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one unrelated change, otherwise LGTM

webapp/package-lock.json Outdated Show resolved Hide resolved
hanzei
hanzei reviewed Mar 1, 2022
View reviewed changes
server/webhook/webhook.go Outdated Show resolved Hide resolved
@hanzei hanzei requested review from mickmister and removed request for iomodo March 1, 2022 13:47
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Mar 5, 2022
@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei
Copy link
Collaborator

hanzei commented May 2, 2022

@sibasankarnayak Heads up that you need to merge master

@dipak-demansol
Copy link
Contributor

@sibasankarnayak i subscribed the issue & issue comment then i added comment like you can see in the attached image then i uploaded This PR build and comy past the same comment again and i'm getting the same data with HTML tag in the mm channel, is there anything wrong i'm doing?
image

@sibasankarnayak
Copy link
Contributor Author

@sibasankarnayak i subscribed the issue & issue comment then i added comment like you can see in the attached image then i uploaded This PR build and comy past the same comment again and i'm getting the same data with HTML tag in the mm channel, is there anything wrong i'm doing? image

can you link the pr which you created

@dipak-demansol
Copy link
Contributor

@sibasankarnayak i subscribed the issue & issue comment then i added comment like you can see in the attached image then i uploaded This PR build and comy past the same comment again and i'm getting the same data with HTML tag in the mm channel, is there anything wrong i'm doing? image

can you link the pr which you created

i did not created a PR, i created issue.

@sibasankarnayak
Copy link
Contributor Author

@sibasankarnayak i subscribed the issue & issue comment then i added comment like you can see in the attached image then i uploaded This PR build and comy past the same comment again and i'm getting the same data with HTML tag in the mm channel, is there anything wrong i'm doing? image

can you link the pr which you created

i did not created a PR, i created issue.

Share the link here then

@dipak-demansol
Copy link
Contributor

@sibasankarnayak i subscribed the issue & issue comment then i added comment like you can see in the attached image then i uploaded This PR build and comy past the same comment again and i'm getting the same data with HTML tag in the mm channel, is there anything wrong i'm doing? image

can you link the pr which you created

i did not created a PR, i created issue.

Share the link here then

link :- https://gitlab.com/dipak.p2/gitlab-plugin-testin/-/issues/19

@sibasankarnayak
Copy link
Contributor Author

@sibasankarnayak i subscribed the issue & issue comment then i added comment like you can see in the attached image then i uploaded This PR build and comy past the same comment again and i'm getting the same data with HTML tag in the mm channel, is there anything wrong i'm doing? image

can you link the pr which you created

i did not created a PR, i created issue.

Share the link here then

link :- https://gitlab.com/dipak.p2/gitlab-plugin-testin/-/issues/19

I see you have added it in a comment
you need to add it to description while creating a issue

@dipak-demansol
Copy link
Contributor

@mickmister @hanzei

  1. so the This PR only remove the HTML data from the description at the time of creating issue & merge request, is this Right?
  2. if User add the HTML data in the issue or merge request Comment then same issue generate so is this right?

@mickmister
Copy link
Contributor

@dipak-demansol The main thing we're accomplishing in this PR is making it so the automated issue and PR creation descriptions are sanitized. Comments can be left untouched

dipak-demansol
dipak-demansol approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@dipak-demansol dipak-demansol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dipak-demansol dipak-demansol added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels May 6, 2022
@DHaussermann
Copy link

/update-branch

@mattermod
Copy link
Contributor

We don't have permissions to update this PR, please contact the submitter to apply the update.

@mickmister mickmister merged commit 244c01d into mattermost:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister mickmister approved these changes

@hanzei hanzei hanzei approved these changes

@dipak-demansol dipak-demansol dipak-demansol approved these changes

Assignees
No one assigned
Labels
Lifecycle/1:stale QA Review Done PR has been approved by QA
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Remove or convert HTML from issue/merge request description
6 participants
@sibasankarnayak @mattermod @hanzei @dipak-demansol @mickmister @DHaussermann